New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librados: replace the var name from onack to complete #13857

Merged
merged 1 commit into from Mar 9, 2017

Conversation

Projects
None yet
2 participants
@liupan1111
Contributor

liupan1111 commented Mar 8, 2017

No description provided.

@liupan1111

This comment has been minimized.

Contributor

liupan1111 commented Mar 8, 2017

@tchaikov , please help take a look, thanks!

@liupan1111 liupan1111 requested a review from tchaikov Mar 8, 2017

@liupan1111

This comment has been minimized.

Contributor

liupan1111 commented Mar 8, 2017

After thinking, I think oncomplete is better... @liewegas @tchaikov , what do you think?

@liupan1111

This comment has been minimized.

Contributor

liupan1111 commented Mar 8, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Mar 8, 2017

"oncomplete" seems clearer, yeah

@liupan1111 liupan1111 changed the title from librados: replace the var name from onact to oncommit for write/remov… to librados: replace the var name from onact to oncommit, which is clearer. Mar 9, 2017

@liupan1111

This comment has been minimized.

Contributor

liupan1111 commented Mar 9, 2017

@liewegas Done.

@liewegas liewegas changed the title from librados: replace the var name from onact to oncommit, which is clearer. to librados: replace the var name from onack to complete Mar 9, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Mar 9, 2017

can you update the commit description to match the new name? otherwise, lgtm!

librados: replace the var name from onact to oncomplete.
Signed-off-by: Pan Liu <pan.liu@istuary.com>
@liupan1111

This comment has been minimized.

Contributor

liupan1111 commented Mar 9, 2017

@liewegas updated the commit description, thanks!

@liewegas liewegas merged commit 83d0704 into ceph:master Mar 9, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@liupan1111 liupan1111 deleted the liupan1111:wip-rename-onack-to-oncommit branch Mar 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment