New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mds: shut down finisher before objecter #13859

Merged
merged 1 commit into from Apr 14, 2017

Conversation

Projects
None yet
3 participants
@jcsp
Contributor

jcsp commented Mar 8, 2017

Some of the finisher contexts would try to call into Objecter.
We mostly are protected from this by mds_lock+the stopping
flag, but at the Filer level there's no mds_lock, so in the
case of file size probing we have a problem.

Fixes: http://tracker.ceph.com/issues/19204
Signed-off-by: John Spray john.spray@redhat.com

@jcsp

This comment has been minimized.

Contributor

jcsp commented Mar 8, 2017

RFC because I haven't fully thought this through, it's just a reaction to the case from http://tracker.ceph.com/issues/19204

@ukernel

This comment has been minimized.

Member

ukernel commented Mar 30, 2017

LGTM. the only issue I can think of is objecter add some contexts to the stopped finisher

John Spray
mds: shut down finisher before objecter
Some of the finisher contexts would try to call into Objecter.
We mostly are protected from this by mds_lock+the stopping
flag, but at the Filer level there's no mds_lock, so in the
case of file size probing we have a problem.

Fixes: http://tracker.ceph.com/issues/19204
Signed-off-by: John Spray <john.spray@redhat.com>

@jcsp jcsp changed the title from [RFC] mds: shut down finisher before objecter to mds: shut down finisher before objecter Apr 13, 2017

@jcsp jcsp merged commit d51c027 into ceph:master Apr 14, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@jcsp jcsp deleted the jcsp:wip-19204 branch Apr 14, 2017

@jcsp

This comment has been minimized.

Contributor

jcsp commented Apr 14, 2017

Merging this because the new order passes tests and the old order was confirmed buggy

ukernel added a commit to ukernel/ceph that referenced this pull request Apr 14, 2017

Merge pull request ceph#13859 from jcsp/wip-19204
mds: shut down finisher before objecter

Reviewed-by: Yan, Zheng <zyan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment