New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd/ReplicatedBackend: clear pull source once we are done with it #13879

Merged
merged 1 commit into from Mar 28, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Member

liewegas commented Mar 8, 2017

68defc2 factored out the clear_pull
behavoir, but we actually need to clear the pull source in
handle_pull_response (even though we don't clear the pulling entry
until the callback) so that we don't clear the pulling entry in
check_recovery_sources. This should restore the clearing behavior
to basically what it was in kraken.

Fixes: http://tracker.ceph.com/issues/19076
Signed-off-by: Samuel Just sjust@redhat.com

ReplicatedBackend: clear pull source once we are done with it
68defc2 factored out the clear_pull
behavoir, but we actually need to clear the pull source in
handle_pull_response (even though we don't clear the pulling entry
until the callback) so that we don't clear the pulling entry in
check_recovery_sources.  This should restore the clearing behavior
to basically what it was in kraken.

Fixes: http://tracker.ceph.com/issues/19076
Signed-off-by: Samuel Just <sjust@redhat.com>

@liewegas liewegas changed the title from ReplicatedBackend: clear pull source once we are done with it to osd/ReplicatedBackend: clear pull source once we are done with it Mar 23, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Mar 24, 2017

retest this please

@liewegas liewegas requested a review from jdurgin Mar 24, 2017

@liewegas liewegas merged commit 3f10704 into ceph:master Mar 28, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment