New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update adminops.rst #13893

Merged
merged 1 commit into from Mar 16, 2017

Conversation

Projects
None yet
4 participants
@hrchu
Contributor

hrchu commented Mar 9, 2017

The link bucket operation requires the bucket-id parameter.

@dmick

This comment has been minimized.

Member

dmick commented Mar 9, 2017

Could we get a commit message that summarizes the change to the doc, rather than just saying "update"? A conventional message would look like
doc/radosgw/adminops.rst: add bucket-id to link bucket

@hrchu

This comment has been minimized.

Contributor

hrchu commented Mar 9, 2017

@dmick the commit already has details below the topic

    The link bucket operation requires the bucket-id parameter.

I will update the commit topic to doc/radosgw/adminops.rst: add bucket-id to link bucket if you do not think that it is too long.

@dmick

This comment has been minimized.

Member

dmick commented Mar 10, 2017

Yes, it's better to quickly summarize in the short message; for one, it may be all you need, and for two, people scanning commits and PR titles see what's going on immediately rather than having to find the whole commit message

doc: add bucket-id to link bucket in adminops.rst
The link bucket operation requires the bucket-id parameter.

Signed-off-by: Chu, Hua-Rong <hrchu@cht.com.tw>
@hrchu

This comment has been minimized.

Contributor

hrchu commented Mar 10, 2017

@dmick agree. Commit updated and still obey 50/72 formatting. Plz take a look.

@cbodley cbodley merged commit f563226 into ceph:master Mar 16, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment