New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: check fsid is normal before osd mkfs #13898

Merged
merged 1 commit into from Apr 23, 2017

Conversation

Projects
None yet
3 participants
@songbaisen

songbaisen commented Mar 9, 2017

osd: check fsid is normal before osd mkfs

Signed-off-by: song baisen song.baisen@zte.com.cn

songbaisen
osd: check fsid is normal before osd mkfs
Signed-off-by: song baisen <song.baisen@zte.com.cn>
@songbaisen

This comment has been minimized.

songbaisen commented Mar 9, 2017

@liewegas Done! 😄

@liewegas liewegas added the cleanup label Mar 9, 2017

@liewegas liewegas added the needs-qa label Mar 9, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Mar 9, 2017

What is the specific motivation for this change? looking at it more closely, i'm worried there is a valid case where the caller isn't explicitly providing the uuid and we are pulling it out of the existing superblock. Not sure, though, there are so many paths to this code...

@songbaisen

This comment has been minimized.

songbaisen commented Mar 10, 2017

@liewegas The motivation is we can early find the error before the osd mkfs.

@tchaikov

This comment has been minimized.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 21, 2017

@liewegas shall we merge this change?

@liewegas liewegas merged commit b25b53f into ceph:master Apr 23, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment