New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mds: fix handling very fast delete ops #13899

Merged
merged 1 commit into from Mar 20, 2017

Conversation

Projects
None yet
3 participants
@jcsp
Contributor

jcsp commented Mar 9, 2017

Deletions can complete so quickly that we're
ready to call execute_item_complete before
the end of execute_item. We could use a finisher
here so that the completion was always called
from outside PurgeQueue::lock, but it's more efficient
to just handle the inline case directly.

Fixes: http://tracker.ceph.com/issues/19245
Signed-off-by: John Spray john.spray@redhat.com

John Spray
mds: fix handling very fast delete ops
Deletions can complete so quickly that we're
ready to call execute_item_complete before
the end of execute_item.  We could use a finisher
here so that the completion was always called
from outside PurgeQueue::lock, but it's more efficient
to just handle the inline case directly.

Fixes: http://tracker.ceph.com/issues/19245
Signed-off-by: John Spray <john.spray@redhat.com>

@jcsp jcsp requested a review from ukernel Mar 9, 2017

@batrick

LGTM

@batrick

This comment has been minimized.

Member

batrick commented Mar 10, 2017

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

@ukernel

This comment has been minimized.

Member

ukernel commented Mar 10, 2017

It works. mds no longer crashes during multimds test

@ukernel ukernel merged commit 6b1473c into ceph:master Mar 20, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment