New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: prevent adding multiple mirror peers to a single pool #13919

Merged
merged 1 commit into from Mar 13, 2017

Conversation

Projects
None yet
3 participants
@dillaman
Contributor

dillaman commented Mar 10, 2017

The rbd-mirror daemon does not currently support replication
from multiple peers. Until that is supported, add a temporary
restriction to prevent confusion.

Fixes: http://tracker.ceph.com/issues/19256
Signed-off-by: Jason Dillaman dillaman@redhat.com

@trociny trociny self-assigned this Mar 11, 2017

@@ -681,7 +681,6 @@ int Mirror<I>::peer_add(librados::IoCtx& io_ctx, std::string *uuid,
return -EINVAL;
}
int r;

This comment has been minimized.

@trociny

trociny Mar 11, 2017

Contributor

@dillaman see jenkins build error

@dillaman dillaman changed the title from librbd: prevent adding multiple mirror peers to a single pool to rbd: prevent adding multiple mirror peers to a single pool Mar 12, 2017

rbd: prevent adding multiple mirror peers to a single pool
The rbd-mirror daemon does not currently support replication
from multiple peers. Until that is supported, add a temporary
restriction to prevent confusion.

Fixes: http://tracker.ceph.com/issues/19256
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
@yangdongsheng

This comment has been minimized.

Member

yangdongsheng commented Mar 13, 2017

Looks Good

@trociny

lgtm

@trociny trociny merged commit 0e7027f into ceph:master Mar 13, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@dillaman dillaman deleted the dillaman:wip-19256 branch Mar 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment