New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: fix a signed/unsigned warning in PG #13922

Merged
merged 1 commit into from Mar 17, 2017

Conversation

Projects
None yet
5 participants
@gregsfortytwo
Member

gregsfortytwo commented Mar 10, 2017

It would be nice if the stats were unsigned, since they can't go negative,
but that's not the world we live in.
(Also, we probably use these structures as deltas which do
need to go negative? I didn't check.)

Signed-off-by: Greg Farnum gfarnum@redhat.com

osd: fix a signed/unsigned warning in PG
It would be nice if the stats were unsigned, since they can't go negative,
but that's not the world we live in.
(Also, we probably use these structures as deltas which *do*
need to go negative? I didn't check.)

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
@gregsfortytwo

This comment has been minimized.

Member

gregsfortytwo commented Mar 10, 2017

Didn't do any real testing of this, but it removed a signed/unsigned warning when compiled.

@liewegas

This comment has been minimized.

Member

liewegas commented Mar 10, 2017

fwiw the stats are deliberately signed so that underflow is more graceful.

@dmick

This comment has been minimized.

Member

dmick commented Mar 10, 2017

I broke the submodule check

@shinobu-x

This comment has been minimized.

Contributor

shinobu-x commented Mar 11, 2017

retest this please

1 similar comment
@shinobu-x

This comment has been minimized.

Contributor

shinobu-x commented Mar 11, 2017

retest this please

@gregsfortytwo

This comment has been minimized.

Member

gregsfortytwo commented Mar 14, 2017

Did this not get through an integration branch yet? Just noticed I still needed to carry the patch through a rebase.

@yuriw yuriw merged commit 9e71f29 into ceph:master Mar 17, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@yuriw

This comment has been minimized.

Contributor

yuriw commented Mar 17, 2017

@gregsfortytwo what is the ticket number?

@gregsfortytwo

This comment has been minimized.

Member

gregsfortytwo commented Mar 17, 2017

I don't think there was one. Just something that popped up when building.

@gregsfortytwo gregsfortytwo deleted the gregsfortytwo:wip-pg-unsigned-warning branch Mar 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment