Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
rbd-nbd: don't ignore --read-only option in BLKROSET ioctl #13944
@liupan1111 I am not sure about the redundant line break. It separates rbd-nbd specific options from ceph generic options, and this looks ok to me. Also this is what i.g. ceph-osd does.
I would more happy if one decreases number of space characters between an option name and its description. This can be done in the same commit where you fix "an image" (I don't see a point in having many commits for updating help info).
As for "readonly" redundant setting, I suppose it was done this way because NBD_SET_FLAGS may fail on older kernels, so this is like a safety guard. See how it is handled in qemu . I would do similarly or leave it as is now.
OK, agree, let's keep it.
Sure, I will do it in same commit with "an".
I agree with this double check, and ok, we could leave it. But there are still two issues for this check:
You can only fix setting