New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw-admin: remove deprecated regionmap commands #13963

Merged
merged 2 commits into from Mar 21, 2017

Conversation

Projects
None yet
2 participants
@cbodley
Contributor

cbodley commented Mar 14, 2017

@oritwas

This comment has been minimized.

Contributor

oritwas commented Mar 14, 2017

@yehudasa @cbodley removing regionmap get command will mean we no longer support the sync agent (there is no problem removing the set command). If we decide not to support it than it should be documented

@oritwas

This comment has been minimized.

Contributor

oritwas commented Mar 14, 2017

@cbodley as teuthology still test the sync agent we need to remove those tests too.

@cbodley

This comment has been minimized.

Contributor

cbodley commented Mar 14, 2017

@oritwas oh yeah, good point. i guess we should leave the regionmap get command as is, and just remove it from the usage. lets wait to remove sync agent tests until we have test_multi.py working in teuthology

edit: the only calls to region-map get are in tasks/util/rgw.py for get_zone_host_and_port() and get_master_zone(). it looks like we could just reimplement those to use period get

@cbodley

This comment has been minimized.

Contributor

cbodley commented Mar 14, 2017

updated tasks/util/rgw.py (needs testing)

re: support for the sync agent, it looks it's using the admin/config rest api to query the regionmap, so i don't think radosgw-admin commands will break the agent itself

@oritwas

This comment has been minimized.

Contributor

oritwas commented Mar 15, 2017

@cbodley , the moment it passes teuthology we can merge it

@cbodley

This comment has been minimized.

cbodley added some commits Mar 14, 2017

rgw-admin: remove deprecated regionmap commands
Fixes: http://tracker.ceph.com/issues/18725

Signed-off-by: Casey Bodley <cbodley@redhat.com>
qa: rgw task uses period instead of region-map
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@oritwas

This comment has been minimized.

Contributor

oritwas commented Mar 20, 2017

jenkins test this please

@oritwas oritwas merged commit 68bc509 into ceph:master Mar 21, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@cbodley cbodley deleted the cbodley:wip-18725 branch Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment