New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: image create validates that pool supports overwrites #13986

Merged
merged 3 commits into from Mar 16, 2017

Conversation

Projects
None yet
2 participants
@dillaman
Contributor

dillaman commented Mar 15, 2017

No description provided.

librbd: removed legacy state machine callbacks from CreateRequest
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

@trociny trociny self-assigned this Mar 15, 2017

// validate the pool supports overwrites. We cannot use rbd_directory
// since the v1 images store the directory as tmap data within the object.
ldout(m_cct, 10) << "validating overwrite support" << dendl;

This comment has been minimized.

@trociny

trociny Mar 15, 2017

Contributor

@dillaman Don't want this and __func__ in the output?

BTW we have some mess in this file: some debug messages contain both this and __func__, some only one of these, some either...

@trociny

trociny Mar 15, 2017

Contributor

@dillaman Don't want this and __func__ in the output?

BTW we have some mess in this file: some debug messages contain both this and __func__, some only one of these, some either...

This comment has been minimized.

@dillaman

dillaman Mar 15, 2017

Contributor

@trociny I switched it over to be consistently defined in the macro

@dillaman

dillaman Mar 15, 2017

Contributor

@trociny I switched it over to be consistently defined in the macro

Show outdated Hide outdated src/librbd/image/CreateRequest.h Outdated

dillaman added some commits Mar 15, 2017

librbd: clean up debug messages within image create state machine
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
librbd: image create validates that pool supports overwrites
Fixes: http://tracker.ceph.com/issues/19081
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

@trociny trociny merged commit 9804468 into ceph:master Mar 16, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@dillaman dillaman deleted the dillaman:wip-19081 branch Mar 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment