Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
rgw_file: fix double unref on rgw_fh for rename #13988
@guihecheng I think you're right about the double unref (not double free, since we are refcounting), but I think my intent (see comment in case 1 /*!LOCKED, -ref */) in the code was that the unlink would be the last valid access to rgw_fh, so rather than omitting to unlock and unref in unlink, we should goto out or return here in rename, because we are not supposed to touch rgw_fh after unlinking it. Can you buy that?