New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/config: set rocksdb_cache_size to OPT_U64 #13995

Merged
merged 1 commit into from Mar 24, 2017

Conversation

Projects
None yet
3 participants
@liuhongtong

liuhongtong commented Mar 16, 2017

OPT_INT is not enough for abundant RAM.

Signed-off-by: liuhongtong hongtong.liu@istuary.com

liuhongtong
common/config: set rocksdb_cache_size to OPT_U64
OPT_INT is not enough for abundant RAM.

Signed-off-by: liuhongtong <hongtong.liu@istuary.com>
@liuhongtong

This comment has been minimized.

Show comment
Hide comment
@liuhongtong

liuhongtong commented Mar 16, 2017

@liupan1111 @yuyuyu101 please take a look.

@liupan1111

This comment has been minimized.

Show comment
Hide comment
@liupan1111

liupan1111 Mar 16, 2017

Contributor

@liuhongtong, the max cap of 32bit is 4G, so is it an usual case the cache of rocksdb larger than that? If there are 10 disks(OSDs) in one server, only rocksdb cache is larger than 40GB?

Contributor

liupan1111 commented Mar 16, 2017

@liuhongtong, the max cap of 32bit is 4G, so is it an usual case the cache of rocksdb larger than that? If there are 10 disks(OSDs) in one server, only rocksdb cache is larger than 40GB?

@liuhongtong

This comment has been minimized.

Show comment
Hide comment
@liuhongtong

liuhongtong Mar 16, 2017

@liupan1111 the max cap of int is 2G. The larger cache can cache more metadata, that is useful to improve performance.

liuhongtong commented Mar 16, 2017

@liupan1111 the max cap of int is 2G. The larger cache can cache more metadata, that is useful to improve performance.

@liupan1111

This comment has been minimized.

Show comment
Hide comment
@liupan1111

liupan1111 Mar 16, 2017

Contributor

I can not make the decision. I find in config_opt.h, many cache options are defined as int, such as:
mon_osd_cache_size, client_cache_size, and so on.

@tchaikov, what is your opinion?

Contributor

liupan1111 commented Mar 16, 2017

I can not make the decision. I find in config_opt.h, many cache options are defined as int, such as:
mon_osd_cache_size, client_cache_size, and so on.

@tchaikov, what is your opinion?

@liewegas

No reason to limit the config via a small integer type (intentionally or not).

@liewegas liewegas merged commit cb6efd8 into ceph:master Mar 24, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment