New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: fix memory leak in delete_obj_aio #13998

Merged
merged 1 commit into from Apr 4, 2017

Conversation

Projects
None yet
5 participants
@wangzhengyong
Contributor

wangzhengyong commented Mar 16, 2017

@prallabh

This comment has been minimized.

Contributor

prallabh commented Mar 16, 2017

@wangzhengyong You have done it for delete_raw_obj_aio(), you may want to fix a similar one in RGWRados::delete_obj_aio() further down in the same file.

@wangzhengyong

This comment has been minimized.

Contributor

wangzhengyong commented Mar 24, 2017

@prallabh done

@wangzhengyong

This comment has been minimized.

Contributor

wangzhengyong commented Mar 27, 2017

please retest

@cbodley cbodley self-assigned this Mar 30, 2017

@@ -12956,6 +12956,7 @@ int RGWRados::delete_raw_obj_aio(const rgw_raw_obj& obj, list<librados::AioCompl
ret = ref.ioctx.aio_operate(ref.oid, c, &op);
if (ret < 0) {
lderr(cct) << "ERROR: AioOperate failed with ret=" << ret << dendl;
delete c;

This comment has been minimized.

@yehudasa

yehudasa Mar 30, 2017

Member

@wangzhengyong should call c->release() instead.

@@ -12994,6 +12995,7 @@ int RGWRados::delete_obj_aio(const rgw_obj& obj,
ret = ref.ioctx.aio_operate(ref.oid, c, &op);
if (ret < 0) {
lderr(cct) << "ERROR: AioOperate failed with ret=" << ret << dendl;
delete c;

This comment has been minimized.

@yehudasa

This comment has been minimized.

@wangzhengyong

wangzhengyong Mar 31, 2017

Contributor

ok,this right

rgw: memory leak in delete_obj_aio
Signed-off-by: wangzhengyong@cmss.chinamobile.com
@cbodley

This comment has been minimized.

@cbodley

This comment has been minimized.

Contributor

cbodley commented Apr 4, 2017

jenkins test this please

@cbodley

cbodley approved these changes Apr 4, 2017

@cbodley cbodley merged commit 5b37718 into ceph:master Apr 4, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment