New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mds: remove legacy "mds tell" command #14015

Merged
merged 3 commits into from Mar 28, 2017

Conversation

Projects
None yet
2 participants
@jcsp
Contributor

jcsp commented Mar 17, 2017

No description provided.

"name=who,type=CephString " \
"name=args,type=CephString,n=N", \
"send command to particular mds", "mds", "rw", "cli,rest")
"send command to particular mds", "mds", "rw", "cli,rest", FLAG(DEPRECATED))

This comment has been minimized.

@batrick

batrick Mar 17, 2017

Member

I think we want FLAG(OBSOLETE). Then we can remove the handler completely from MDSMonitor.cc as this code will catch the obsolete command:

https://github.com/jcsp/ceph/blob/7d7cc63e2a131cb9eccde9b78be9253648d01796/src/mon/Monitor.cc#L2836-L2843

John Spray added some commits Mar 16, 2017

John Spray
mon: remove `mds tell` command
Fixes: http://tracker.ceph.com/issues/19288
Signed-off-by: John Spray <john.spray@redhat.com>
John Spray
mds: remove legacy MMonCommand handling
Fixes: http://tracker.ceph.com/issues/19288
Signed-off-by: John Spray <john.spray@redhat.com>
John Spray
mon: mark newfs with OBSOLETE flag
+ remove the explicit handler for it.

Signed-off-by: John Spray <john.spray@redhat.com>
@jcsp

This comment has been minimized.

Contributor

jcsp commented Mar 21, 2017

Updated -- TIL about the OBSOLETE option

@batrick

This comment has been minimized.

Member

batrick commented Mar 24, 2017

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

@jcsp jcsp merged commit 4812068 into ceph:master Mar 28, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@jcsp jcsp deleted the jcsp:wip-19288 branch Mar 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment