New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: changed the return type of ImageRequestWQ::discard() #14032

Merged
merged 1 commit into from Apr 6, 2017

Conversation

Projects
None yet
3 participants
@joscollin
Member

joscollin commented Mar 18, 2017

Changed the return type of ImageRequestWQ::discard() to ssize_t, as it returns a valid size or a negative value to indicate an error.

Fixes: http://tracker.ceph.com/issues/18511
Signed-off-by: Jos Collin jcollin@redhat.com

rbd: changed the return type of ImageRequestWQ::discard()
Changed the return type of ImageRequestWQ::discard() to ssize_t, as it returns a valid size or a negative value to indicate an error.

Fixes: http://tracker.ceph.com/issues/18511
Signed-off-by: Jos Collin <jcollin@redhat.com>
@badone

badone approved these changes Mar 19, 2017

LGTM

@dillaman

The actual issue is that the public API is still tied to an int return type -- and the public API cannot be changed w/o breaking backward compatibility [1]. This internal change brings us one step closer (although it doesn't address the full issue).

[1] http://tracker.ceph.com/issues/16465

@joscollin

This comment has been minimized.

Member

joscollin commented Mar 20, 2017

@dillaman : Could you please show me the public API you are talking about, so that I can have a look at it ?

@dillaman

This comment has been minimized.

Contributor

dillaman commented Mar 20, 2017

@joscollin

This comment has been minimized.

Member

joscollin commented Mar 28, 2017

@dillaman I think it is better to update the Public API as a different PR. Could you please merge this PR for now ? Thanks.

@dillaman

This comment has been minimized.

Contributor

dillaman commented Mar 28, 2017

@joscollin This PR is already approved and waiting for QA (as per the label). The API can't be changed at this point and probably serves few purposes.

@dillaman dillaman changed the title from rbd: changed the return type of ImageRequestWQ::discard() to librbd: changed the return type of ImageRequestWQ::discard() Apr 6, 2017

@dillaman dillaman merged commit d366311 into ceph:master Apr 6, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@joscollin

This comment has been minimized.

Member

joscollin commented Apr 6, 2017

@dillaman Thank you.

@joscollin joscollin deleted the joscollin:wip-18511-returntype branch Apr 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment