New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd-nbd: fix typo in comment #14034

Merged
merged 1 commit into from Mar 21, 2017

Conversation

Projects
None yet
3 participants
@liupan1111
Contributor

liupan1111 commented Mar 18, 2017

No description provided.

@liupan1111

This comment has been minimized.

Contributor

liupan1111 commented Mar 19, 2017

@trociny minor change. thanks.

@liupan1111 liupan1111 requested a review from trociny Mar 19, 2017

@liupan1111 liupan1111 assigned liupan1111 and unassigned liupan1111 Mar 19, 2017

@trociny

This comment has been minimized.

Contributor

trociny commented Mar 19, 2017

@liupan1111 I am not sure we do intentionally changes like your first commit. We have tabs/space mix through all the code, and personally I in favour to use only one style, and prefer spaces. The funny thing is though that the file header:

// -*- mode:C++; tab-width:8; c-basic-offset:2; indent-tabs-mode:t -*-

tells that tabs should be used. And frequently I am a source of these tabs because my emacs uses this settings instead of my preferences.

Jason usually changes tabs to spaces, but only for lines where he updates the code.

If changing this just to fix the style, at the first we should officially agree that tabs is wrong (and fix the headers then). Note, changes like these add additional difficulties when e.g. researching a regression.

@dillaman what do you think?

@trociny trociny changed the title from rbd-nbd: fixed comment issue, change RBD_DO_IT to NBD_DO_IT. to rbd-nbd: fix typo in comment Mar 19, 2017

@liupan1111

This comment has been minimized.

Contributor

liupan1111 commented Mar 20, 2017

@trociny @dillaman The current coding style of existing code makes me confused... sometimes, some code only use spaces, but some others, space and tab mix ...

But for my first commit, the issue is: no matter tab or spacing, the code should be kept in alignment, but it was not.

@dillaman

This comment has been minimized.

Contributor

dillaman commented Mar 21, 2017

Sadly -- the Ceph coding standard permits the mixture of tabs and spaces [1], so we aren't going to change that here. I agree w/ @trociny that the first commit is not helpful.

[1] https://github.com/ceph/ceph/blob/master/CodingStyle#L75

rbd-nbd: fix typo in comment.
Signed-off-by: Pan Liu <liupan1111@gmail.com>
@liupan1111

This comment has been minimized.

Contributor

liupan1111 commented Mar 21, 2017

ok, i just removed the first commit.

@trociny trociny merged commit 089a024 into ceph:master Mar 21, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment