Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
rbd-nbd: fix typo in comment #14034
@liupan1111 I am not sure we do intentionally changes like your first commit. We have tabs/space mix through all the code, and personally I in favour to use only one style, and prefer spaces. The funny thing is though that the file header:
tells that tabs should be used. And frequently I am a source of these tabs because my emacs uses this settings instead of my preferences.
Jason usually changes tabs to spaces, but only for lines where he updates the code.
If changing this just to fix the style, at the first we should officially agree that tabs is wrong (and fix the headers then). Note, changes like these add additional difficulties when e.g. researching a regression.
@dillaman what do you think?
Sadly -- the Ceph coding standard permits the mixture of tabs and spaces , so we aren't going to change that here. I agree w/ @trociny that the first commit is not helpful.