New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/TrackedOp: allow dumping historic ops sorted by duration #14050

Merged
merged 1 commit into from Mar 23, 2017

Conversation

Projects
None yet
3 participants
@branch-predictor
Member

branch-predictor commented Mar 20, 2017

Currently dump_historic_ops dumps ops sorted by their initiation time,
what may not have any relation to how long it took, and sorting output
of that command by op duration is neither fast nor convenient.
New asok command ("dump_historic_ops_by_duration") outputs the same
op list, but ordered by their duration time (longest first).

Signed-off-by: Piotr Dałek piotr.dalek@corp.ovh.com

@liewegas

This comment has been minimized.

Member

liewegas commented Mar 20, 2017

Is the ordering by initiation useful, or would it be better to just make the original commant sort by duration? (FWIW that's what I thought it did.)

@branch-predictor

This comment has been minimized.

Member

branch-predictor commented Mar 21, 2017

@liewegas I think it's useful, at least this can indicate how ops stacked on each other (i.e. if some op blocked others, it could help locating the offending one and reason for the block).

@liewegas liewegas changed the title from TrackedOp: allow dumping historic ops sorted by duration to common/TrackedOp: allow dumping historic ops sorted by duration Mar 21, 2017

@liewegas liewegas added the needs-qa label Mar 21, 2017

@branch-predictor

This comment has been minimized.

Member

branch-predictor commented Mar 21, 2017

@liewegas I saw a reference to dump_historic_ops in mds code (https://github.com/ceph/ceph/blob/master/src/mds/MDSRank.cc#L1718), do we want this there too?

@liewegas

This comment has been minimized.

Member

liewegas commented Mar 21, 2017

TrackedOp: allow dumping historic ops sorted by duration
Currently dump_historic_ops dumps ops sorted by their initiation time,
which may not have any relation to how long it took, and sorting output
of that command by op duration is neither fast nor convenient.
New asok command ("dump_historic_ops_by_duration") outputs the same
op list, but ordered by their duration time (longest first).

Signed-off-by: Piotr Dałek <piotr.dalek@corp.ovh.com>
@branch-predictor

This comment has been minimized.

Member

branch-predictor commented Mar 22, 2017

Updated.

@yuriw yuriw merged commit 18ca002 into ceph:master Mar 23, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@branch-predictor branch-predictor deleted the ovh:bp-dump-ops-by-duration branch Mar 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment