New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: stop indefinite thread waiting in krbd.cc #14051

Merged
merged 1 commit into from May 5, 2017

Conversation

Projects
None yet
3 participants
@SpandanKumarSahu
Contributor

SpandanKumarSahu commented Mar 20, 2017

No description provided.

@tchaikov tchaikov added the rbd label Mar 22, 2017

src/krbd.cc Outdated
@@ -42,6 +42,8 @@
using namespace std;
#define POLL_TIMEOUT 120000

This comment has been minimized.

@dillaman

dillaman Mar 27, 2017

Contributor

Nit: I would prefer a static const instead of a #define

@dillaman

Please (1) update your commit message to remove "bug XYZ" from the subject and instead of "rbd: XYZ", (2) reference the associated tracker ticket in the commit message via a "Fixes: " line

rbd: stop indefinite thread waiting in krbd.cc
Fixes: http://tracker.ceph.com/issues/17195

Signed-off-by: Spandan Kumar Sahu <spandankumarsahu@gmail.com>
@SpandanKumarSahu

This comment has been minimized.

Contributor

SpandanKumarSahu commented Mar 27, 2017

@dillaman Made the changes, as said.

@dillaman dillaman changed the title from bug #17195: Stop indefinite thread waiting in krbd.cc to rbd: stop indefinite thread waiting in krbd.cc Mar 27, 2017

@dillaman dillaman added the cleanup label Mar 27, 2017

@dillaman dillaman added the needs-qa label Mar 27, 2017

@dillaman dillaman merged commit 128f593 into ceph:master May 5, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment