New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd/PG: reset the missing set when restarting backfill #14053

Merged
merged 1 commit into from Aug 6, 2017

Conversation

Projects
None yet
4 participants
@jdurgin
Member

jdurgin commented Mar 20, 2017

During split we restart backfill by resetting last_backfill. When we
are backfilling, we assume our missing set is only relevant before
last_backfill, so we need to reset it here as well.

Fixes: http://tracker.ceph.com/issues/19191
Signed-off-by: Josh Durgin jdurgin@redhat.com

PG: reset the missing set when restarting backfill
During split we restart backfill by resetting last_backfill. When we
are backfilling, we assume our missing set is only relevant before
last_backfill, so we need to reset it here as well.

Fixes: http://tracker.ceph.com/issues/19191
Signed-off-by: Josh Durgin <jdurgin@redhat.com>

@jdurgin jdurgin requested a review from dzafman Mar 28, 2017

@dzafman

Seems reasonable. How have you tested this?

@jdurgin

This comment has been minimized.

Member

jdurgin commented Mar 28, 2017

I wasn't able to construct a test case to reproduce the issue yet - should probably add that since it's rare to hit via randomized testing

@liewegas liewegas added the needs-qa label Apr 25, 2017

@liewegas liewegas changed the title from PG: reset the missing set when restarting backfill to osd/PG: reset the missing set when restarting backfill Apr 25, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Apr 28, 2017

@jdurgin shall we merge this or wait for a test? i'm ok with merging.

@jdurgin jdurgin added this to the luminous milestone Aug 5, 2017

@liewegas liewegas merged commit 1a93635 into ceph:master Aug 6, 2017

3 of 4 checks passed

make check (arm64) running make check
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment