New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: common/config_opts.h: Remove deprecated osd_compact_leveldb_on_mount option #14059

Merged
merged 1 commit into from Mar 22, 2017

Conversation

Projects
None yet
5 participants
@vumrao
Contributor

vumrao commented Mar 21, 2017

common/config_opts.h: Remove deprecated osd_compact_leveldb_on_mount option.
This option was removed in commit 1a5dea7.

Fixes: http://tracker.ceph.com/issues/19318

Signed-off-by: Vikhyat Umrao vumrao@redhat.com

common/config_opts.h: Remove deprecated osd_compact_leveldb_on_mount …
…option.

This option was removed in commit 1a5dea7.

Fixes: http://tracker.ceph.com/issues/19318

Signed-off-by: Vikhyat Umrao <vumrao@redhat.com>
@amitkumar50

Review Done. Ok

@amitkumar50

Review Done. Approved

@joscollin

Looks Good to me. Please update the tracker status.

@vumrao

This comment has been minimized.

Contributor

vumrao commented Mar 22, 2017

@joscollin @amitkumar50 review is required by core team then only it can be merged.
@tchaikov @badone could you please review and merge it.

@tchaikov tchaikov merged commit 55a4cb8 into ceph:master Mar 22, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@vumrao

This comment has been minimized.

Contributor

vumrao commented Mar 22, 2017

Thanks @tchaikov :)

@joscollin

This comment has been minimized.

Member

joscollin commented Mar 23, 2017

@vumrao: review is required by core team then only it can be merged.
Who talked about merging here ? Even if it is Reviewed and Approved, still it may not be merged and the PR should wait for all checks to be passed.

@vumrao

This comment has been minimized.

Contributor

vumrao commented Mar 23, 2017

@joscollin Ahh that message I added as just an FYI message because all checks were already passed and then I added Kefu and Brad :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment