New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: combine unstable stats with info.stats when publish stats to osd #14060

Merged
merged 2 commits into from Mar 23, 2017

Conversation

Projects
None yet
3 participants
@LiumxNL
Contributor

LiumxNL commented Mar 21, 2017

fix no io stat shows in "ceph -s" output when doing read only

Signed-off-by: Mingxin Liu mingxin@xsky.com

@LiumxNL

This comment has been minimized.

Contributor

LiumxNL commented Mar 21, 2017

@tchaikov @liewegas pls review, thanks!

LiumxNL added some commits Mar 21, 2017

osd: should consider unstable_stats when publish stats to osd
Signed-off-by: Mingxin Liu <mingxin@xsky.com>
osd: no need to set dirty_info flag, append_log() will do this
Signed-off-by: Mingxin Liu <mingxin@xsky.com>

@LiumxNL LiumxNL changed the title from osd: sum detal_stats generated by read ops when complete_read_ctx to osd: combine unstable stats with info.stats when publish stats to osd Mar 21, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Mar 21, 2017

This looks reasonable, but we may want to wait until we have stats going to mgr instead of the mon. I seem to remember being sloppy about this in the past, having problems, and eventually switching to a much stricter model.. but I don't remember the details. Can you look back in the history a bit and see if there was a specific change to only report stable stats, or has it always been that way?

@LiumxNL

This comment has been minimized.

Contributor

LiumxNL commented Mar 21, 2017

@liewegas this appear after a much stricter publish model made by commit 97c1881

@liewegas

Ok, this looks fine. The old code was also including unstable_stats in what we send to the mon, so there's no real change here!

@yuriw yuriw merged commit 0620e81 into ceph:master Mar 23, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment