New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph-disk: Reporting /sys directory in get_partition_dev() #14080

Merged
1 commit merged into from Mar 22, 2017

Conversation

Projects
None yet
1 participant
@ErwanAliasr1
Contributor

ErwanAliasr1 commented Mar 22, 2017

When get_partition_dev() fails, it reports the following message :
ceph_disk.main.Error: Error: partition 2 for /dev/sdb does not appear to exist
The code search for a directory inside the /sys/block/get_dev_name(os.path.realpath(dev)).

The issue here is the error message doesn't report that path when failing while it might be involved in.

This patch is about reporting where the code was looking at when trying to estimate if the partition was available.

Signed-off-by: Erwan Velu erwan@redhat.com

ceph-disk: Reporting /sys directory in get_partition_dev()
When get_partition_dev() fails, it reports the following message :
    ceph_disk.main.Error: Error: partition 2 for /dev/sdb does not appear to exist
The code search for a directory inside the /sys/block/get_dev_name(os.path.realpath(dev)).

The issue here is the error message doesn't report that path when failing while it might be involved in.

This patch is about reporting where the code was looking at when trying to estimate if the partition was available.

Signed-off-by: Erwan Velu <erwan@redhat.com>

@ErwanAliasr1 ErwanAliasr1 requested a review from Mar 22, 2017

@ghost ghost added cleanup core labels Mar 22, 2017

@ghost

This comment has been minimized.

ghost commented Mar 22, 2017

pushed to ceph-ci, when it is ready run
teuthology-suite -k distro --verbose --suite ceph-disk --ceph evelu-ceph-disk --machine-type vps

@ghost

ghost approved these changes Mar 22, 2017

@ghost ghost merged commit 950abe1 into master Mar 22, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@liewegas liewegas deleted the evelu-ceph-disk branch Aug 25, 2017

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment