Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script: ceph-release-notes: use https instead of http #14103

Merged
merged 1 commit into from Mar 24, 2017

Conversation

Projects
None yet
3 participants
@tchaikov
Copy link
Contributor

tchaikov commented Mar 23, 2017

Signed-off-by: Kefu Chai kchai@redhat.com

script: ceph-release-notes: use https instead of http
Signed-off-by: Kefu Chai <kchai@redhat.com>
@smithfarm
Copy link
Contributor

smithfarm left a comment

Not sure what the motivation is here, the links in question work fine without SSL. (They are redirected.)

Also, e.g. "git clone http://github.com/ceph/ceph" works fine.

This isn't an objection, per se, just don't see the need.

@smithfarm smithfarm requested a review from jcsp Mar 23, 2017

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

tchaikov commented Mar 23, 2017

@smithfarm now more and more browsers make https the default, some of them even warn at seeing http, github offers its web pages via https, so let's embrace https also. that's the motivation.

@tchaikov tchaikov merged commit 6a771d1 into ceph:master Mar 24, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-https-github branch Mar 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.