New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mds: include advisory `path` field in damage #14104

Merged
merged 1 commit into from Apr 18, 2017

Conversation

Projects
None yet
2 participants
@jcsp
Contributor

jcsp commented Mar 23, 2017

This will just be whatever path we were looking
at at the point that damage was notified -- no
intention whatsoever of providing any up to date
path or resolution when there are multiple paths
to an inode.

Fixes: http://tracker.ceph.com/issues/18509
Signed-off-by: John Spray john.spray@redhat.com

@jcsp jcsp requested a review from gregsfortytwo Mar 23, 2017

@@ -370,25 +370,26 @@ void ScrubStack::_validate_inode_done(CInode *in, int r,
LogChannelRef clog = mdcache->mds->clog;
const ScrubHeaderRefConst header = in->scrub_info()->header;
std::string path;
in->make_path_string(path, true);

This comment has been minimized.

@ukernel

ukernel Mar 29, 2017

Member

make_path_string when !result.passed_validation. This can save a few cpu cycles

John Spray
mds: include advisory `path` field in damage
This will just be whatever path we were looking
at at the point that damage was notified -- no
intention whatsoever of providing any up to date
path or resolution when there are multiple paths
to an inode.

Fixes: http://tracker.ceph.com/issues/18509
Signed-off-by: John Spray <john.spray@redhat.com>
@jcsp

This comment has been minimized.

Contributor

jcsp commented Apr 13, 2017

@ukernel updated as per your suggestion

@jcsp

This comment has been minimized.

@ukernel ukernel self-requested a review Apr 18, 2017

@jcsp jcsp merged commit a762ad4 into ceph:master Apr 18, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@jcsp jcsp deleted the jcsp:wip-18509 branch Apr 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment