New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: typo in hit_set_search_last_n #14108

Merged
merged 1 commit into from Mar 28, 2017

Conversation

Projects
None yet
5 participants
@svenseeberg
Contributor

svenseeberg commented Mar 23, 2017

Documentation of pools describes hit_set_grade_search_last_n which does not exist in the source code. hit_set_search_last_n exists in source but not in documentation. Assuming that this is just a typo, the documentation entry was changed from hit_set_grade_search_last_n to hit_set_search_last_n.

@badone badone requested a review from dragonylffly Mar 23, 2017

@badone

This comment has been minimized.

Contributor

badone commented Mar 23, 2017

@dragonylffly and @LiumxNL could you take a look at this please?

@badone badone assigned dragonylffly and unassigned dragonylffly Mar 23, 2017

@badone

This comment has been minimized.

Contributor

badone commented Mar 23, 2017

@sven15 can you add a signed off line to your commit ("-s")?

@badone

This comment has been minimized.

Contributor

badone commented Mar 23, 2017

Test this please

renamed hit_set_grade_search_last_n to hit_set_search_last_n
Signed-off-by: Sven Seeberg <sseebergelverfeldt@suse.com>
@badone

This comment has been minimized.

Contributor

badone commented Mar 25, 2017

Test this please

@badone badone self-assigned this Mar 25, 2017

@badone

badone approved these changes Mar 27, 2017

LGTM and thanks for this first contribution @sven15

@badone

This comment has been minimized.

Contributor

badone commented Mar 27, 2017

Test this please

@dragonylffly

This comment has been minimized.

Contributor

dragonylffly commented Mar 28, 2017

lgtm

@johnwilkins johnwilkins merged commit f2dfa64 into ceph:master Mar 28, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment