New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: return the version id in get object and object metadata request. #14117

Merged
merged 1 commit into from Jun 7, 2017

Conversation

Projects
None yet
4 participants
@zhangsw
Contributor

zhangsw commented Mar 24, 2017

If bucket versioning is enabled, S3 will return the version id in get object and object metadata request.

Fixes: http://tracker.ceph.com/issues/19370

Signed-off-by: Zhang Shaowen zhangshaowen@cmss.chinamobile.com

rgw: return the version id in get object and object metadata request.
Fixes: http://tracker.ceph.com/issues/19370

Signed-off-by: Zhang Shaowen <zhangshaowen@cmss.chinamobile.com>

@yehudasa yehudasa self-assigned this Mar 30, 2017

@zhangsw

This comment has been minimized.

Contributor

zhangsw commented Apr 1, 2017

jenkins test this please

@yehudasa

lgtm

@yehudasa

This comment has been minimized.

Member

yehudasa commented Apr 6, 2017

@zhangsw can you try adding a test in s3-tests to check this?

@zhangsw

This comment has been minimized.

Contributor

zhangsw commented Apr 7, 2017

@yehudasa OK, I'll do it.

@zhangsw

This comment has been minimized.

Contributor

zhangsw commented Apr 10, 2017

@yehudasa I've add the test case for this PR ceph/s3-tests#157

@yehudasa

This comment has been minimized.

Member

yehudasa commented Jun 7, 2017

Not sure why this was closed, reopenning.

@yehudasa yehudasa merged commit 7bd8773 into ceph:master Jun 7, 2017

2 of 3 checks passed

default Build started sha1 is merged.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details

@zhangsw zhangsw deleted the zhangsw:fix-rgw-getobjectmetadata-bug branch Jun 7, 2017

@cbodley

This comment has been minimized.

Contributor

cbodley commented Jun 13, 2017

@yehudasa this is causing test_versioning_obj_plain_null_version_overwrite() to fail, because boto will update Key.version_id based on this header in calls to Key.get_contents_as_string(). i opened ceph/s3-tests#166 to fix the test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment