Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: correct the quota section #14122

Merged
merged 1 commit into from Mar 29, 2017

Conversation

Projects
None yet
4 participants
@hrchu
Copy link
Contributor

hrchu commented Mar 24, 2017

test in ceph version 10.2.2 (45107e2)

@cbodley

This comment has been minimized.

Copy link
Contributor

cbodley commented Mar 27, 2017

@hrchu thanks for looking into this! i agree that the current docs are a bit confusing and incomplete. but based on the code, it looks like both methods (http params and json) are supported. from rgw_rest_user.cc:729,

/**
 * set quota
 *
 * two different ways to set the quota info: as json struct in the message body or via http params.

also, both the uid and bucket parameters are valid depending on whether quota-scope is user or bucket

@cbodley cbodley self-assigned this Mar 27, 2017

@hrchu

This comment has been minimized.

Copy link
Contributor Author

hrchu commented Mar 28, 2017

Cool, I will update this later.

@hrchu hrchu force-pushed the hrchu:rgwadmin-doc-quota branch from d347f61 to c99e916 Mar 28, 2017

@hrchu

This comment has been minimized.

Copy link
Contributor Author

hrchu commented Mar 28, 2017

@cbodley the PR is updated, plz have a look.

I do minimal modification so that people can follow the document and successfully "enable" the quota without getting 400 bad request. 😹

@dang

dang approved these changes Mar 28, 2017

@cbodley

This comment has been minimized.

Copy link
Contributor

cbodley commented Mar 28, 2017

@hrchu thanks, looks good. we'd like to backport this fix to jewel and kraken, so i created a ticket at http://tracker.ceph.com/issues/19397. could you please add this to your commit message?

Fixes: http://tracker.ceph.com/issues/19397

@hrchu hrchu force-pushed the hrchu:rgwadmin-doc-quota branch from c99e916 to 0c4800f Mar 28, 2017

@hrchu

This comment has been minimized.

Copy link
Contributor Author

hrchu commented Mar 28, 2017

@cbodley sure, updated.

@cbodley

This comment has been minimized.

Copy link
Contributor

cbodley commented Mar 28, 2017

@hrchu there are some new changes to rgw_admin.cc mixed in, can you remove those?

hrchu
doc: rgw: correct the quota section
Add the missing option and fix typo.

Fixes: http://tracker.ceph.com/issues/19397

Signed-off-by: Chu, Hua-Rong <hrchu@cht.com.tw>

@hrchu hrchu force-pushed the hrchu:rgwadmin-doc-quota branch from 0c4800f to 51a8826 Mar 29, 2017

@hrchu

This comment has been minimized.

Copy link
Contributor Author

hrchu commented Mar 29, 2017

@cbodley updated. I should check it.

@cbodley cbodley merged commit 4b73fcb into ceph:master Mar 29, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.