Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add some undocumented options to rbd-nbd #14134

Merged
merged 1 commit into from Mar 25, 2017

Conversation

Projects
None yet
4 participants
@wangzhengyong
Copy link
Contributor

wangzhengyong commented Mar 25, 2017

@liupan1111
Copy link
Contributor

liupan1111 left a comment

you missed the "." at the end of lines, could you add them?

@wangzhengyong wangzhengyong force-pushed the wangzhengyong:doc branch from d2bdda6 to 2e2b922 Mar 25, 2017

@wangzhengyong

This comment has been minimized.

Copy link
Contributor Author

wangzhengyong commented Mar 25, 2017

@liupan1111

This comment has been minimized.

Copy link
Contributor

liupan1111 commented Mar 25, 2017

@trociny please do The merge if you feel ok.

@trociny

This comment has been minimized.

Copy link
Contributor

trociny commented Mar 25, 2017

@wangzhengyong You also need to update Synopsis

@wangzhengyong wangzhengyong force-pushed the wangzhengyong:doc branch from 2e2b922 to 02add58 Mar 25, 2017

@wangzhengyong

This comment has been minimized.

Copy link
Contributor Author

wangzhengyong commented Mar 25, 2017

@trociny sorry, i forgot it

wangzhengyong
doc: add some undocumented options to rbd-nbd
Signed-off-by: wangzhengyong@cmss.chinamobile.com

@dillaman dillaman added the rbd label Mar 25, 2017

@@ -28,11 +28,23 @@ Options
Use *ceph.conf* configuration file instead of the default
``/etc/ceph/ceph.conf`` to determine monitor addresses during startup.

.. option:: --read-only

Map readonly.

This comment has been minimized.

Copy link
@dillaman

dillaman Mar 25, 2017

Contributor

Nit: "read-only"


.. option:: --exclusive

Forbid other clients write.

This comment has been minimized.

Copy link
@dillaman

dillaman Mar 25, 2017

Contributor

Nit: "Forbid writes by other clients"

This comment has been minimized.

Copy link
@trociny

trociny Mar 25, 2017

Contributor

@dillaman Oh, sorry, I just merged it and did not notice your comments.

This comment has been minimized.

Copy link
@trociny

trociny Mar 25, 2017

Contributor

@dillaman May be then also fix this in --help output?

@trociny trociny merged commit 2e97d18 into ceph:master Mar 25, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@liupan1111

This comment has been minimized.

Copy link
Contributor

liupan1111 commented Mar 26, 2017

@trociny I've create a PR to fix the nits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.