New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: ceph-release-notes: prefixes and pep8 compliance #14156

Merged
merged 9 commits into from Apr 3, 2017

Conversation

Projects
None yet
3 participants
@smithfarm
Contributor

smithfarm commented Mar 26, 2017

A variety of cleanups

smithfarm added some commits Mar 26, 2017

tools: ceph-release-notes: global inits in alphabetical order
Signed-off-by: Nathan Cutler <ncutler@suse.com>
tools: ceph-release-notes: add and use prefixes list
Put all the recognized prefixes in one place for ease of maintenance.

Signed-off-by: Nathan Cutler <ncutler@suse.com>

@smithfarm smithfarm requested review from theanalyst and Mar 26, 2017

smithfarm added some commits Mar 26, 2017

tools: ceph-release-notes: sync labels with github reality
This is a list of github labels in ceph/ceph - sync it with current state of
github.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
tools: ceph-release-notes: s/labels/issue_labels/
Variable contains only labels active for a particular issue, so
name it more appropriately in preparation for the next commit.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
tools: ceph-release-notes: put github repo labels in a global variable
Signed-off-by: Nathan Cutler <ncutler@suse.com>
tools: ceph-release-notes: document global variables
Document the global variables we introduce in this patch set.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
tools: ceph-release-notes: use msg prefix instead of msgr
msgr is easy to confuse with "mgr".

msg is more widely used and in this context it's not likely that anyone
will take it to mean "monosodium glutamate".

Signed-off-by: Nathan Cutler <ncutler@suse.com>
tools: ceph-release-notes: add rbd-mirror and rbd-nbd prefixes
Signed-off-by: Nathan Cutler <ncutler@suse.com>
tools: ceph-release-notes: pep8 compliance
This commit makes the script pass flake8

Signed-off-by: Nathan Cutler <ncutler@suse.com>
@ghost

ghost approved these changes Mar 26, 2017

@ghost

This comment has been minimized.

ghost commented Mar 26, 2017

jenkins test this please

@theanalyst

This comment has been minimized.

Member

theanalyst commented Mar 27, 2017

Looks good, one more improvement, (which need not be in this pr, for later) is to maybe output both the plaintext & rst version to different outfiles, avoids running the same script twice & copy stdout to create these

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Mar 27, 2017

Thanks; I'll run a quick test before merging.

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Mar 27, 2017

@theanalyst I'll look at splitting the plaintext and rst output to different files. Thanks!

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Mar 31, 2017

@smithfarm is this script tested by our qa suite? i am guessing that we can remove the needs-qa label?

@smithfarm smithfarm removed the needs-qa label Mar 31, 2017

@theanalyst

This comment has been minimized.

Member

theanalyst commented Apr 3, 2017

@smithfarm tested by hand, works for me. We can add the plaintext rst as a different PR IMO.

@smithfarm smithfarm merged commit c35a721 into ceph:master Apr 3, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@smithfarm smithfarm deleted the smithfarm:release-notes-add-rbd-mirror branch Apr 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment