New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: pass an uint64_t to clip_io() as the 3rd param #14159

Merged
merged 1 commit into from Mar 27, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Contributor

tchaikov commented Mar 27, 2017

because, on arm32, size_t is "unsigned", while uint64_t is "long long
unsigned int", compiler is not able to promote the former to the latter
automatically. and ImageRequest::Extents::value_type::second_type is
indeed uint64_t, which is expected by clip_io(). so let's just use
"auto" here.

Fixes: http://tracker.ceph.com/issues/18938
Signed-off-by: Kefu Chai kchai@redhat.com

librbd: pass an uint64_t to clip_io() as the 3rd param
because, on arm32, size_t is "unsigned", while uint64_t is "long long
unsigned int", compiler is not able to promote the former to the latter
automatically. and ImageRequest::Extents::value_type::second_type is
indeed uint64_t, which is expected by clip_io(). so let's just use
"auto" here.

Fixes: http://tracker.ceph.com/issues/18938
Signed-off-by: Kefu Chai <kchai@redhat.com>
@dillaman

lgtm

@dillaman dillaman merged commit 91ce416 into ceph:master Mar 27, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-rbd-size_t-is-not-uint64_t-on-arm32 branch Mar 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment