New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw/lifecycle: do not send lifecycle rules when GetLifeCycle failed #14160

Merged
merged 1 commit into from Apr 4, 2017

Conversation

Projects
None yet
4 participants
@Liuchang0812
Contributor

Liuchang0812 commented Mar 27, 2017

Now, RGW will send two HTTP responses when GetLifeCycle failed. The first one is
Error Respnse like 404, and the second is lifecycle rules. It will breaks s3 sdk
and s3 utilities.

Fixes: http://tracker.ceph.com/issues/19363
Signed-off-by: liuchang0812 liuchang0812@gmail.com

rgw/lifecycle: do not send lifecycle rules when GetLifeCycle failed
Now, RGW will send two HTTP responses when GetLifeCycle failed. The first one is
Error Respnse like 404, and the second is lifecycle rules. It will breaks s3 sdk
and s3 utilities.

Fixes: http://tracker.ceph.com/issues/19363
Signed-off-by: liuchang0812 <liuchang0812@gmail.com>
@Liuchang0812

This comment has been minimized.

Show comment
Hide comment
@Liuchang0812

Liuchang0812 Mar 27, 2017

Contributor

@yehudasa @mattbenjamin @cbodley

Would you mind taking a look here? Need we backport this bug-fix to K?

Contributor

Liuchang0812 commented Mar 27, 2017

@yehudasa @mattbenjamin @cbodley

Would you mind taking a look here? Need we backport this bug-fix to K?

@dang

dang approved these changes Mar 27, 2017

@Liuchang0812

This comment has been minimized.

Show comment
Hide comment
@Liuchang0812

Liuchang0812 Mar 29, 2017

Contributor

Hi, is there similiar problems elsethere?

Contributor

Liuchang0812 commented Mar 29, 2017

Hi, is there similiar problems elsethere?

@cbodley

This comment has been minimized.

Show comment
Hide comment
@cbodley

cbodley Apr 4, 2017

Contributor

Hi, is there similiar problems elsethere?

@Liuchang0812 hopefully not, but extra testing is the only way to know for sure

Contributor

cbodley commented Apr 4, 2017

Hi, is there similiar problems elsethere?

@Liuchang0812 hopefully not, but extra testing is the only way to know for sure

@cbodley cbodley merged commit f3d6c28 into ceph:master Apr 4, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@Liuchang0812

This comment has been minimized.

Show comment
Hide comment
@Liuchang0812

Liuchang0812 Apr 5, 2017

Contributor

@cbodley Yep, Adding some fault-injected UnitTestes is nessesary

Contributor

Liuchang0812 commented Apr 5, 2017

@cbodley Yep, Adding some fault-injected UnitTestes is nessesary

@Liuchang0812 Liuchang0812 deleted the Liuchang0812:wip-19363-fix-lc-two-response branch Apr 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment