Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigation for #16842, validate sessions after load #14164

Merged
merged 2 commits into from Apr 18, 2017

Conversation

Projects
None yet
2 participants
@jcsp
Copy link
Contributor

jcsp commented Mar 27, 2017

No description provided.

@jcsp jcsp force-pushed the jcsp:wip-16842-mitigation branch from 6e66945 to f4634b2 Mar 27, 2017

find an issue

@ukernel

This comment has been minimized.

Copy link
Member

ukernel commented Mar 30, 2017

There is no guarantee that states of on-disk inotable/sessiontable are synchronized. we should validate sessions after journal replay.

@jcsp jcsp force-pushed the jcsp:wip-16842-mitigation branch from f4634b2 to 065cfaa Apr 13, 2017

@jcsp

This comment has been minimized.

Copy link
Contributor Author

jcsp commented Apr 13, 2017

@ukernel you're right, I've updated it to only call validate_sessions after replay

John Spray added some commits Mar 27, 2017

John Spray
mds: operator<< for Session
Use this to get a nice human readable name
when available (also including the session id in
parentheses)

Signed-off-by: John Spray <john.spray@redhat.com>
John Spray
mds: validate prealloc_inos on sessions after load
Mitigates http://tracker.ceph.com/issues/16842

Signed-off-by: John Spray <john.spray@redhat.com>

@jcsp jcsp force-pushed the jcsp:wip-16842-mitigation branch from 065cfaa to c39aaf9 Apr 13, 2017

@jcsp

This comment has been minimized.

@jcsp jcsp merged commit c4f8f61 into ceph:master Apr 18, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@jcsp jcsp deleted the jcsp:wip-16842-mitigation branch Apr 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.