New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/ceph_context: fewer warnings about experimental features #14170

Merged
merged 1 commit into from Apr 2, 2017

Conversation

Projects
None yet
4 participants
@liewegas
Member

liewegas commented Mar 28, 2017

As Pete Zaitcev points out, check_experimental_feature_enabled
warns when an actual experimental feature is used; we don't need
to also warn that we might use it here.

This means we don't notice when a feature is enabled but it isn't
used, but that noise arguably has no value.

Signed-off-by: Sage Weil sage@redhat.com

This is an update/rebase of #8547

common/ceph_context: fewer warnings about experimental features
As Pete Zaitcev points out, check_experimental_feature_enabled
warns when an actual experimental feature is used; we don't need
to also warn that we might use it here.

This means we don't notice when a feature is enabled but it isn't
used, but that noise arguably has no value.

Signed-off-by: Sage Weil <sage@redhat.com>
@zaitcev

This comment has been minimized.

Contributor

zaitcev commented Mar 28, 2017

Acked-by: Pete Zaitcev zaitcev@redhat.com

@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented Mar 28, 2017

LGTM
And yes please, this clogs the log files with testing.

@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented Mar 28, 2017

I also have another PR that prevents some more useless logging while running tests during development.
#10384.
Which could be modified to acustome others, but it is in the same line as this PR

@liewegas liewegas added the needs-qa label Mar 28, 2017

@tchaikov

This comment has been minimized.

@tchaikov tchaikov merged commit ef00668 into ceph:master Apr 2, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment