New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon/OSDMonitor: Clean up: delete extra S signature for plural #14174

Merged
merged 1 commit into from Apr 4, 2017

Conversation

Projects
None yet
3 participants
@shinobu-x
Contributor

shinobu-x commented Mar 28, 2017

Signed-off-by: Shinobu Kinjo shinobu@redhat.com

@smithfarm smithfarm added bug fix core cleanup and removed bug fix labels Mar 28, 2017

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Mar 28, 2017

@shinobu-x The description of the commit message "Clean up: Delete extra S signature for plural" could be changed to "mon: Delete extra S signature for plural"? The prefix is supposed to denote which Ceph component the patch is changing.

Thanks for noticing and fixing this!

@shinobu-x

This comment has been minimized.

Contributor

shinobu-x commented Mar 28, 2017

@smithfarm Thanks for your suggestion which is good. I will follow you.

@shinobu-x shinobu-x changed the title from Clean up: Delete extra S signature for plural to mon: Delete extra S signature for plural Mar 28, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Mar 28, 2017

@shinobu-x the title of the pull request is different from that of the commit(s) in that PR. could you update the commit also?

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Mar 28, 2017

@shinobu-x The command to update the commit message is ceph commit --amend and then git push -f to push the change to github.

@shinobu-x

This comment has been minimized.

Contributor

shinobu-x commented Mar 28, 2017

@tchaikov @smithfarm Thanks for your help. Much appreciated :)

@shinobu-x shinobu-x changed the title from mon: Delete extra S signature for plural to mon/OSDMonitor: Clean up: delete extra S signature for plural Apr 3, 2017

mon/OSDMonitor: Clean up: delete extra S signature for plural
Signed-off-by: Shinobu Kinjo <shinobu@redhat.com>

@tchaikov tchaikov added mon needs-qa and removed core labels Apr 4, 2017

@smithfarm smithfarm merged commit 26c1b4c into ceph:master Apr 4, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment