New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg/async/rdma: RDMA-CM Initialize device on first connect #14179

Merged
merged 2 commits into from Mar 28, 2017

Conversation

Projects
None yet
3 participants
@Adirl

Adirl commented Mar 28, 2017

No description provided.

amirv added some commits Feb 6, 2017

msg/async/rdma: Initialize device on first connect
Allocate Device's IB resources only when first connect for a device is
called.

Also, removed Infiniband::MemoryManager::Chunk::post_srq() which is not
used anywhere in the code.

Issue: 995322
Change-Id: I2ac1e36aff645ad7d8bbc06c87530bf33c4b3ecf
Signed-off-by: Amir Vadai <amir@vadai.me>
msg/async/rdma: Extract sockets stuff from RDMAStack.h
This is a preparation commit, in order to make review easier. In this
commit I move code from RDMAStack.h into the new file
RDMAConnectedSocketImpl.h - without changing the code.

In the next commit, the actual logic changes will be done and socket
classes will be split into a base RDMAConnected classes and child
classes with TCP connection establishment specific code.

Issue: 995322
Change-Id: I639fda490a6fbd02addb95d3158c5ac1e7390ef0
Signed-off-by: Amir Vadai <amir@vadai.me>
@Adirl

This comment has been minimized.

Adirl commented Mar 28, 2017

@yuyuyu101 @amirv @orendu @saritz @DanielBar-On

RDMA-CM, 3rd patch set
verified on vstart + traffic

let's merge this before pushing more patches.

@yuyuyu101

This comment has been minimized.

Member

yuyuyu101 commented Mar 28, 2017

is it possible that we can make one connection span on multi device?

@Adirl

This comment has been minimized.

Adirl commented Mar 28, 2017

@yuyuyu101
why do you think we should do that ?

@yuyuyu101

This comment has been minimized.

Member

yuyuyu101 commented Mar 28, 2017

I'm just thinking of we can round robin on multi devices?

@amirv

This comment has been minimized.

Contributor

amirv commented Mar 28, 2017

@yuyuyu101 , I guess you're talking about the server socket.
As it is designed now, a socket belong to a device.
We do round robin in the polling() function.
and In RDMA-CM the server listen on all devices - but when a socket is created it belongs to a single device.

@Adirl

@yuyuyu101

pretty good on cleaning

@yuyuyu101 yuyuyu101 merged commit b164ac5 into ceph:master Mar 28, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment