New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mds: use same inode count in health check as in trim #14197

Merged
merged 1 commit into from Apr 20, 2017

Conversation

Projects
None yet
3 participants
@jcsp
Contributor

jcsp commented Mar 28, 2017

Otherwise we could have a strange situation in which trimming
is working fine, but the health check thinks there's a problem.

Seen in: http://tracker.ceph.com/issues/19395

Signed-off-by: John Spray john.spray@redhat.com

@gregsfortytwo

This comment has been minimized.

Member

gregsfortytwo commented Mar 28, 2017

Want to change the conditional as well as the output? ;)

That said, this still looks to me like there's a memory leak. Or maybe CInode::count() just got broken? (I think we used to have a pool allocator and now it's just relying on tcmalloc?)

@jcsp

This comment has been minimized.

Contributor

jcsp commented Mar 28, 2017

Want to change the conditional as well as the output? ;)

Oops, fixed!

That said, this still looks to me like there's a memory leak. Or maybe CInode::count() just got broken? (I think we used to have a pool allocator and now it's just relying on tcmalloc?)

Yeah, still investigating. It's not the CInode::count thing, because this is kraken code.

John Spray
mds: use same inode count in health check as in trim
Otherwise we could have a strange situation in which trimming
is working fine, but the health check thinks there's a problem.

Fixes: http://tracker.ceph.com/issues/19395
Signed-off-by: John Spray <john.spray@redhat.com>

@jcsp jcsp requested a review from batrick Apr 14, 2017

@jcsp

This comment has been minimized.

@batrick

This comment has been minimized.

Member

batrick commented Apr 19, 2017

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

@jcsp jcsp merged commit 9264e1c into ceph:master Apr 20, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@jcsp jcsp deleted the jcsp:wip-19395-counter branch Apr 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment