Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crush: bucket: crush_add_uniform_bucket_item should check for uniformity #14208

Merged
merged 4 commits into from Apr 10, 2017

Conversation

Projects
None yet
3 participants
@ghost
Copy link

ghost commented Mar 28, 2017

And a few minor documentation fixes while we're at it.

sahid added some commits Mar 23, 2017

crush: nit: fix duplicate words 'of'
Signed-off-by: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@redhat.com>
crush: nit: fix documentation warning with crush_destroy_bucket(...)
crush/crush.h:429: warning: argument 'bucket' of command @param is not
found in the argument list of crush_destroy_bucket(struct crush_bucket
*b)

Signed-off-by: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@redhat.com>
crush: bucket: crush_add_uniform_bucket_item should check for uniformity
When defining a bucket using alg CRUSH_BUCKET_UNIFORM, the item weight
set during creation of bucket should be used to ensure that for every
new items added, the weights are the same.

Signed-off-by: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@redhat.com>
crush: docfix to refer -EINVAL if weight is invalid for uniform bucket
Signed-off-by: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@redhat.com>

@ghost ghost added cleanup core labels Mar 28, 2017

@ghost ghost assigned sahid Mar 28, 2017

@ghost ghost requested a review from liewegas Mar 28, 2017

@ghost

This comment has been minimized.

Copy link
Author

ghost commented Mar 28, 2017

Looks like master is broken, try again later

C{++} Error in /home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_op.cc:881:17
@ghost

This comment has been minimized.

Copy link
Author

ghost commented Mar 30, 2017

jenkins test this please, we're hoping master is in a better mood today !

@liewegas liewegas added the needs-qa label Apr 4, 2017

@yuriw yuriw merged commit 4adfd07 into ceph:master Apr 10, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.