Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: allow offline conversion of filestore -> bluestore (or anything else) #14210

Merged
merged 10 commits into from Apr 6, 2017

Conversation

Projects
None yet
2 participants
@liewegas
Copy link
Member

liewegas commented Mar 28, 2017

  • make filestore store collection bit width
  • fix up legacy filestore instances with bit width on osd start
  • implement ceph-objectstore-tool 'dup' op to make an offline copy of an entire osd

liewegas added some commits Mar 28, 2017

ceph-objectstore-tool: create 'dup' command
Signed-off-by: Sage Weil <sage@redhat.com>
os/memstore: implement collection_bits()
Signed-off-by: Sage Weil <sage@redhat.com>
os/kstore: implement collection_bits
Signed-off-by: Sage Weil <sage@redhat.com>
os/filestore: stub out collectionn_bits
Doesn't work yet, just a placeholder.

Signed-off-by: Sage Weil <sage@redhat.com>
os/ObjectStore: make collection_bits required
Signed-off-by: Sage Weil <sage@redhat.com>
os/filestore: store collection bits
Set on create, adjust on split, return from
collection_bits().

Signed-off-by: Sage Weil <sage@redhat.com>
os/ObjectStore: add collection_set_bits op
This is only for FileStore, the only one that doesn't
already store it.

Signed-off-by: Sage Weil <sage@redhat.com>
os/filestore: implement collection_set_bits
Signed-off-by: Sage Weil <sage@redhat.com>
osd/PG: fix filestore collections' bits
Legacy FileStore didn't store the bit width of a
collection, which prevents you from duplicating/
converting the store to something else (BlueStore). Fix
it up on startup.

Signed-off-by: Sage Weil <sage@redhat.com>
test/osd/osd-dup.sh: filestore -> bluestore conversion test
Pretty basic; just verifies the osd restarts and scrub
doesn't immediately turn up problems.

Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas force-pushed the liewegas:wip-osd-dup branch from 905ed6d to c279a2d Mar 29, 2017

@liewegas liewegas requested a review from dzafman Mar 29, 2017

cerr << "failed to copy " << s << ": " << err << std::endl;
} else {
string d = dstpath + "/keyring";
bl.write_file(d.c_str(), 0600);

This comment has been minimized.

Copy link
@dzafman

dzafman Apr 3, 2017

Member

Is dstpath the right place for the keyring file when bluestone is on a block device. Where are the files type, fsid, keyring, whoami... stored in that case?

@liewegas

This comment has been minimized.

Copy link
Member Author

liewegas commented Apr 3, 2017

@dzafman

dzafman approved these changes Apr 5, 2017

Copy link
Member

dzafman left a comment

👍

@liewegas liewegas merged commit 092aa00 into ceph:master Apr 6, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@liewegas liewegas deleted the liewegas:wip-osd-dup branch Apr 6, 2017

@liewegas

This comment has been minimized.

Copy link
Member Author

liewegas commented Apr 6, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.