New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasks/workunit.py: when cloning, use --depth=1 #14214

Merged
merged 1 commit into from Mar 29, 2017

Conversation

Projects
None yet
2 participants
@dmick
Member

dmick commented Mar 29, 2017

Help avoid killing git.ceph.com. A depth 1 clone takes about
7 seconds, whereas a full one takes about 3:40 (much of it
waiting for the server to create a huge compressed pack)

Signed-off-by: Dan Mick dan.mick@redhat.com

tasks/workunit.py: when cloning, use --depth=1
Help avoid killing git.ceph.com.  A depth 1 clone takes about
7 seconds, whereas a full one takes about 3:40 (much of it
waiting for the server to create a huge compressed pack)

Signed-off-by: Dan Mick <dan.mick@redhat.com>
@dmick

This comment has been minimized.

Member

dmick commented Mar 29, 2017

Tested with teuthology --suite-path:

interactive-on-error: true
roles: 
  - [mon.a, osd.0, client.0]
  - [mon.b, mon.c, osd.1, osd.2]
tasks:
  - install:
      branch: master
  - ceph:
  - workunit:
      clients:
        client.0: [cephtool]

Got this failure:

cluster [WRN] pg 3.0 has invalid (post-split) stats; must scrub before tier agent can activate

I doubt it's connected.

@@ -321,6 +321,7 @@ def _run_tests(ctx, refspec, role, tests, env, subdir=None, timeout=None):
run.Raw('&&'),
'git',
'clone',
'--depth=1',

This comment has been minimized.

@tchaikov

tchaikov Mar 29, 2017

Contributor

we can also pass --no-checkout to git clone, to save some time to check out the HEAD. we will run git checkout later on anyway.

This comment has been minimized.

@dmick

dmick Mar 29, 2017

Member

we could, but the time is totally dominated by the remote pack creation and transmission. I can't observe any difference at all from --no-checkout.

@tchaikov tchaikov added the tests label Mar 29, 2017

@dmick

This comment has been minimized.

Member

dmick commented Mar 29, 2017

I guess the failure is not surprising; this test hasn't run for 13 months:

http://pulpito.ceph.com/?suite=rados%3Asingleton%3Aall

@dmick dmick merged commit b227a70 into ceph:master Mar 29, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@dmick dmick deleted the dmick:wip-workunit-shallow-clone branch Mar 29, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Mar 30, 2017

this breaks all the workunit tests, if they are not running against master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment