New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: clean up Invalid return value judgment #14219

Merged
merged 1 commit into from Mar 30, 2017

Conversation

Projects
None yet
2 participants
@ShiqiCooperation
Contributor

ShiqiCooperation commented Mar 29, 2017

Signed-off-by: shiqi 1454927420@qq.com

@ShiqiCooperation

This comment has been minimized.

Show comment
Hide comment
@ShiqiCooperation

ShiqiCooperation Mar 29, 2017

Contributor

BlueStore::_do_truncate return value is always 0 .
So the return value does not need to be judged whether it is less than 0

Contributor

ShiqiCooperation commented Mar 29, 2017

BlueStore::_do_truncate return value is always 0 .
So the return value does not need to be judged whether it is less than 0

@liewegas

This comment has been minimized.

Show comment
Hide comment
@liewegas

liewegas Mar 29, 2017

Member

In that case we should change _do_truncate() to return void at the same time. as long as it is returning a value we should be checking it (even if it is always 0).

Member

liewegas commented Mar 29, 2017

In that case we should change _do_truncate() to return void at the same time. as long as it is returning a value we should be checking it (even if it is always 0).

os/bluestore: clean up Invalid return value judgment
Signed-off-by: shiqi <1454927420@qq.com>
@ShiqiCooperation

This comment has been minimized.

Show comment
Hide comment
@ShiqiCooperation

ShiqiCooperation Mar 30, 2017

Contributor

_do_truncate and _truncate() changed to return void

Contributor

ShiqiCooperation commented Mar 30, 2017

_do_truncate and _truncate() changed to return void

@liewegas liewegas merged commit b782b37 into ceph:master Mar 30, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment