rbd-nbd: s/cpp_error/cpp_strerror/ to fix FTBFS #14223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
force-pushed
the
wip-rbd-nbd-ftbfs
branch
from
bca9548
to
f2bf328
Compare
the build failure was introduced by ff4dcf0 Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-rbd-nbd-ftbfs
branch
from
f2bf328
to
c12ecd9
Compare
|
retest this please |
|
@tchaikov thanks for this fix. But I am curious about why it passed in the jenkins test of my PR? |
liupan1111
approved these changes
Mar 29, 2017
|
@liupan1111 "make check" does not build all packaged artifacts. so it'd be ideal if we can ensure that our change at least builds locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the build failure was introduced by ff4dcf0
Signed-off-by: Kefu Chai kchai@redhat.com