New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd-nbd: s/cpp_error/cpp_strerror/ to fix FTBFS #14223

Merged
merged 1 commit into from Mar 29, 2017

Conversation

Projects
None yet
3 participants
@tchaikov
Contributor

tchaikov commented Mar 29, 2017

the build failure was introduced by ff4dcf0

Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov tchaikov added the rbd label Mar 29, 2017

@tchaikov tchaikov requested review from trociny, dillaman and liupan1111 Mar 29, 2017

rbd-nbd: s/cpp_error/cpp_strerror/ to fix FTBFS
the build failure was introduced by ff4dcf0

Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov added the bug fix label Mar 29, 2017

@dillaman

This comment has been minimized.

Contributor

dillaman commented Mar 29, 2017

retest this please

@dillaman

lgtm

@liupan1111

This comment has been minimized.

Contributor

liupan1111 commented Mar 29, 2017

@tchaikov thanks for this fix. But I am curious about why it passed in the jenkins test of my PR?

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Mar 29, 2017

@liupan1111 "make check" does not build all packaged artifacts. so it'd be ideal if we can ensure that our change at least builds locally.

@tchaikov tchaikov merged commit 06256a5 into ceph:master Mar 29, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-rbd-nbd-ftbfs branch Mar 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment