New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd: remove ceph-create-keys from presets #14226

Merged
merged 2 commits into from Mar 31, 2017

Conversation

Projects
None yet
5 participants
@leseb
Contributor

leseb commented Mar 29, 2017

ceph-create-keys unit file was removed here:

As a consequence the systemctl preset command now fails to run since the
unit does not exist anymore. Due to the redirection in /dev/null we
don't know what's happening.

Ultimately the mon unit doesn't get enabled and the mon service won't
start after reboot.
Removing the old/non-existent unit makes the command succeed now.

Signed-off-by: Sébastien Han seb@redhat.com

systemd: remove ceph-create-keys from presets
ceph-create-keys unit file was removed here:

* 8bcb464
* dc5fe8d

As a consequence the systemctl preset command now fails to run since the
unit does not exist anymore. Due to the redirection in /dev/null we
don't know what's happening.

Ultimately the mon unit doesn't get enabled and the mon service won't
start after reboot.
Removing the old/non-existent unit makes the command succeed now.

Signed-off-by: Sébastien Han <seb@redhat.com>
@ktdreyer

This comment has been minimized.

Member

ktdreyer commented Mar 29, 2017

This is happening in an %if 0%{?suse_version} conditional. Did you test it on SUSE?

@ktdreyer ktdreyer requested a review from smithfarm Mar 29, 2017

@@ -1190,7 +1190,7 @@ fi
%post mon
%if 0%{?suse_version}
if [ $1 -eq 1 ] ; then
/usr/bin/systemctl preset ceph-create-keys@\*.service ceph-mon@\*.service ceph-mon.target >/dev/null 2>&1 || :
/usr/bin/systemctl preset ceph-mon@\*.service ceph-mon.target >/dev/null 2>&1 || :
fi
%endif
%if 0%{?fedora} || 0%{?rhel}

This comment has been minimized.

@ktdreyer

ktdreyer Mar 29, 2017

Member

does the same thing need to happen in the fedora/rhel case here?

This comment has been minimized.

@leseb

leseb Mar 29, 2017

Contributor

Yes!

@leseb

This comment has been minimized.

Contributor

leseb commented Mar 29, 2017

I tested this on CentOS.

@smithfarm

@leseb Can you add a commit for the fedora/rhel code just a couple lines down, i.e. remove the non-existent service from this line:

%systemd_post ceph-create-keys@\*.service ceph-mon@\*.service ceph-mon.target

Good catch! Thanks.

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Mar 29, 2017

@leseb There are several more mentions of the ceph-create-keys unit file in the ceph-mon scriptlets. It would be great if we could remove them all in this one PR.

systemd: remove all occurence of ceph-create-keys
ceph-create-keys unit file does not exist anymore so there is no need to
call it.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb

This comment has been minimized.

Contributor

leseb commented Mar 30, 2017

@smithfarm sure, done.

@vasukulkarni

This comment has been minimized.

Member

vasukulkarni commented Mar 30, 2017

can a build be generated with this change in ceph-ci? i would like to scheduled systemd test from smoke suite.

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Mar 30, 2017

@vasukulkarni Pushed wip-preset-mon to ceph-ci just now - please let me know if there is any problem.

@smithfarm

This will need backport to kraken. Opened http://tracker.ceph.com/issues/19431 - whoever merges this PR should change the status of that tracker to "Pending Backport"

@vasukulkarni

This comment has been minimized.

Member

vasukulkarni commented Mar 31, 2017

This test is passing on centOS with one of my other tracker issue fixed as well, but on xenial after reboot i dont see the mon daemon's up

http://pulpito.ceph.com/vasu-2017-03-30_21:08:42-smoke-wip-preset-mon---basic-vps/

mon's dont come up: https://paste.fedoraproject.org/paste/xf6cWnkRHzkL9U1K1IRLrF5M1UNdIGYhyRLivL9gydE=/raw

@vasukulkarni

This comment has been minimized.

Member

vasukulkarni commented Mar 31, 2017

If you want to rerun: teuthology-suite -s smoke -c wip-preset-mon -m vps --suite-repo git://github.com/ceph/ceph.git --suite-branch wip-systemd --suite-relpath qa --filter systemd

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Mar 31, 2017

The Xenial failure can't be related to this PR, which is limited to ceph.spec.in.

@vasukulkarni vasukulkarni merged commit b6895fb into master Mar 31, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@vasukulkarni vasukulkarni deleted the preset-mon branch Mar 31, 2017

@vasukulkarni

This comment has been minimized.

Member

vasukulkarni commented Mar 31, 2017

thanks, will file an issue for xenial.

leseb added a commit to ceph/ceph-ansible that referenced this pull request Apr 6, 2017

enable ceph-mon.target service after monitor start
ceph-create-keys unit file was removed here:

* ceph/ceph@8bcb464
* ceph/ceph@dc5fe8d

As a consequence the systemctl preset command now fails to run since the
unit does not exist anymore. Due to the redirection in /dev/null we
don't know what's happening.

Ultimately the mon unit doesn't get enabled and the mon service won't
start after reboot.
Removing the old/non-existent unit makes the command succeed now.

ceph fix: ceph/ceph#14226

Signed-off-by: WingkaiHo <sanguosfiang@163.com>
Co-Authored-By: Sébastien Han <seb@redhat.com>
@ktdreyer

This comment has been minimized.

Member

ktdreyer commented Apr 6, 2017

I don't think we have a tracker to track the jewel backport here?

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Apr 6, 2017

@ktdreyer The tracker is http://tracker.ceph.com/issues/19431 but we've still got systemd/ceph-create-keys@.service in jewel so I only backported it to kraken for now.

@ktdreyer

This comment has been minimized.

Member

ktdreyer commented Apr 6, 2017

Oh, right, thanks!

ceph-jenkins pushed a commit to ceph/ansible-ceph-mon that referenced this pull request Apr 7, 2017

enable ceph-mon.target service after monitor start
ceph-create-keys unit file was removed here:

* ceph/ceph@8bcb464
* ceph/ceph@dc5fe8d

As a consequence the systemctl preset command now fails to run since the
unit does not exist anymore. Due to the redirection in /dev/null we
don't know what's happening.

Ultimately the mon unit doesn't get enabled and the mon service won't
start after reboot.
Removing the old/non-existent unit makes the command succeed now.

ceph fix: ceph/ceph#14226

Signed-off-by: WingkaiHo <sanguosfiang@163.com>
Co-Authored-By: Sébastien Han <seb@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment