systemd: remove ceph-create-keys from presets #14226
Conversation
ceph-create-keys unit file was removed here: * 8bcb464 * dc5fe8d As a consequence the systemctl preset command now fails to run since the unit does not exist anymore. Due to the redirection in /dev/null we don't know what's happening. Ultimately the mon unit doesn't get enabled and the mon service won't start after reboot. Removing the old/non-existent unit makes the command succeed now. Signed-off-by: Sébastien Han <seb@redhat.com>
|
This is happening in an |
| @@ -1190,7 +1190,7 @@ fi | |||
| %post mon | |||
| %if 0%{?suse_version} | |||
| if [ $1 -eq 1 ] ; then | |||
| /usr/bin/systemctl preset ceph-create-keys@\*.service ceph-mon@\*.service ceph-mon.target >/dev/null 2>&1 || : | |||
| /usr/bin/systemctl preset ceph-mon@\*.service ceph-mon.target >/dev/null 2>&1 || : | |||
| fi | |||
| %endif | |||
| %if 0%{?fedora} || 0%{?rhel} | |||
There was a problem hiding this comment.
does the same thing need to happen in the fedora/rhel case here?
|
I tested this on CentOS. |
There was a problem hiding this comment.
@leseb Can you add a commit for the fedora/rhel code just a couple lines down, i.e. remove the non-existent service from this line:
%systemd_post ceph-create-keys@\*.service ceph-mon@\*.service ceph-mon.target
Good catch! Thanks.
|
@leseb There are several more mentions of the |
ceph-create-keys unit file does not exist anymore so there is no need to call it. Signed-off-by: Sébastien Han <seb@redhat.com>
|
@smithfarm sure, done. |
|
can a build be generated with this change in ceph-ci? i would like to scheduled systemd test from smoke suite. |
|
@vasukulkarni Pushed |
There was a problem hiding this comment.
This will need backport to kraken. Opened http://tracker.ceph.com/issues/19431 - whoever merges this PR should change the status of that tracker to "Pending Backport"
|
This test is passing on centOS with one of my other tracker issue fixed as well, but on xenial after reboot i dont see the mon daemon's up http://pulpito.ceph.com/vasu-2017-03-30_21:08:42-smoke-wip-preset-mon---basic-vps/ mon's dont come up: https://paste.fedoraproject.org/paste/xf6cWnkRHzkL9U1K1IRLrF5M1UNdIGYhyRLivL9gydE=/raw |
|
If you want to rerun: teuthology-suite -s smoke -c wip-preset-mon -m vps --suite-repo git://github.com/ceph/ceph.git --suite-branch wip-systemd --suite-relpath qa --filter systemd |
|
The Xenial failure can't be related to this PR, which is limited to |
|
thanks, will file an issue for xenial. |
ceph-create-keys unit file was removed here: * ceph/ceph@8bcb464 * ceph/ceph@dc5fe8d As a consequence the systemctl preset command now fails to run since the unit does not exist anymore. Due to the redirection in /dev/null we don't know what's happening. Ultimately the mon unit doesn't get enabled and the mon service won't start after reboot. Removing the old/non-existent unit makes the command succeed now. ceph fix: ceph/ceph#14226 Signed-off-by: WingkaiHo <sanguosfiang@163.com> Co-Authored-By: Sébastien Han <seb@redhat.com>
|
I don't think we have a tracker to track the jewel backport here? |
|
@ktdreyer The tracker is http://tracker.ceph.com/issues/19431 but we've still got |
|
Oh, right, thanks! |
ceph-create-keys unit file was removed here:
As a consequence the systemctl preset command now fails to run since the
unit does not exist anymore. Due to the redirection in /dev/null we
don't know what's happening.
Ultimately the mon unit doesn't get enabled and the mon service won't
start after reboot.
Removing the old/non-existent unit makes the command succeed now.
Signed-off-by: Sébastien Han seb@redhat.com