New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd-mirror: pool watcher should track mirror uuid #14240

Merged
merged 3 commits into from Apr 6, 2017

Conversation

Projects
None yet
2 participants
@dillaman
Contributor

dillaman commented Mar 29, 2017

No description provided.

@trociny trociny self-assigned this Mar 30, 2017

@@ -95,6 +95,9 @@ void PoolWatcher<I>::init(Context *on_finish) {
m_on_init_finish = on_finish;
}
assert(!m_refresh_in_progress);
m_refresh_in_progress = true;

This comment has been minimized.

@trociny

trociny Mar 30, 2017

Contributor

@dillaman I am just wondering why do you access m_refresh_in_progress not holding the lock (here and inprocess_refresh_images below)?

@trociny

This comment has been minimized.

Contributor

trociny commented Mar 30, 2017

@dillaman s/tracker/track/ in the PR title?

@dillaman dillaman changed the title from rbd-mirror: pool watcher should tracker mirror uuid to rbd-mirror: pool watcher should trackrmirror uuid Mar 30, 2017

@dillaman dillaman changed the title from rbd-mirror: pool watcher should trackrmirror uuid to rbd-mirror: pool watcher should track mirror uuid Mar 30, 2017

dillaman added some commits Mar 29, 2017

rbd-mirror: re-refresh pool if scheduled while refresh in-flight
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
cls_rbd: async mirror_uuid_get support
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: pool watcher should retrieve the mirror uuid
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
@dillaman

This comment has been minimized.

Contributor

dillaman commented Mar 30, 2017

@trociny update pushed

@dillaman

This comment has been minimized.

Contributor

dillaman commented Mar 30, 2017

retest this please

trociny pushed a commit to trociny/ceph that referenced this pull request Apr 2, 2017

Mykola Golub
rbd-mirror: pool watcher should track mirror uuid by dillaman · Pull …
…Request ceph#14240 · ceph/ceph · GitHub

* wip-rbd-mirror-peer-uuids:
  rbd-mirror: pool watcher should retrieve the mirror uuid
  cls_rbd: async mirror_uuid_get support
  rbd-mirror: re-refresh pool if scheduled while refresh in-flight
mirror_uuid = m_mirror_uuid;
removed_image_ids = std::move(m_image_ids);
m_image_ids.clear();

This comment has been minimized.

@trociny

trociny Apr 4, 2017

Contributor

@dillaman clear is not necessary after move?

This comment has been minimized.

@dillaman

dillaman Apr 4, 2017

Contributor

@trociny Per the standard, the object is left in an "undefined" state after a move and you are required to put it back into a well-defined state. For STL collections, the "clear" method is used to accomplish that.

@trociny

trociny approved these changes Apr 5, 2017

lgtm

@trociny trociny merged commit af80ee6 into ceph:master Apr 6, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@dillaman dillaman deleted the dillaman:wip-rbd-mirror-peer-uuids branch Apr 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment