New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdma: msg/async/rdma: Device::last_poll_dev must be positive #14250

Merged
merged 1 commit into from Mar 30, 2017

Conversation

Projects
None yet
3 participants
@Adirl

Adirl commented Mar 30, 2017

Make Device::last_poll_dev unsigned - it could overlap and should not
be negative.
Also, add missing initialization.

Signed-off-by: Amir Vadai amir@vadai.me

@Adirl

This comment has been minimized.

Adirl commented Mar 30, 2017

@yuyuyu101
bug fix

@@ -137,7 +137,7 @@ class DeviceList {
int num;
Device** devices;
int last_poll_dev;
unsigned int last_poll_dev = 0;

This comment has been minimized.

@yuyuyu101

yuyuyu101 Mar 30, 2017

Member

unsigned is enough, "unsigned int" make confusing

msg/async/rdma: Device::last_poll_dev must be positive
Make Device::last_poll_dev `unsigned` - it could overlap and should not
be negative.
Also, add missing initialization.

Change-Id: I558f02292ae4f5d1ce48d9bcda5047d382604237
Signed-off-by: Amir Vadai <amir@vadai.me>
@Adirl

This comment has been minimized.

Adirl commented Mar 30, 2017

@yuyuyu101
Done

@yuyuyu101 yuyuyu101 merged commit 1f67500 into ceph:master Mar 30, 2017

2 of 3 checks passed

default Build started sha1 is merged.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details

@theanalyst theanalyst changed the title from msg/async/rdma: Device::last_poll_dev must be positive to rdma: msg/async/rdma: Device::last_poll_dev must be positive Apr 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment