New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radosgw-admin: new 'global quota' commands update period config #14252

Merged
merged 7 commits into from Apr 5, 2017

Conversation

Projects
None yet
2 participants
@cbodley
Contributor

cbodley commented Mar 30, 2017

global quota settings are stored in RGWPeriodConfig which is included in RGWPeriod, but radosgw-admin didn't expose any way to set them. and as part of the period, there was no way to use global quotas in a default non-multisite configuration where no period/realm exists

this patch set turns RGWPeriodConfig into a distinct rados object, so it can be used in the absence of a period configuration. when a period does exist, the period update and period commit commands handle this local period config object the same as local zone/zonegroup objects - RGWPeriod::update() reads the config object and stores it in the staging period, and RGWPeriod::reflect() writes the period's config to this local object

new radosgw-admin commands period quota set/enable/disable match the logic and arguments of the normal quota set/enable/disable commands. there's an additional period quota get command to query the current configuration

Fixes: http://tracker.ceph.com/issues/19409

@cbodley

This comment has been minimized.

Contributor

cbodley commented Mar 30, 2017

requesting feedback on naming of the commands. period quota or realm quota may be confusing for non-multisite configurations. global quota maybe?

@oritwas

This comment has been minimized.

Contributor

oritwas commented Apr 3, 2017

I agree global quota is clearer

cbodley added some commits Mar 29, 2017

rgw: remove unused RGWPeriod::update(RGWZoneGroupMap)
Signed-off-by: Casey Bodley <cbodley@redhat.com>
rgw: allow RGWPeriodConfig to be stored separately
Signed-off-by: Casey Bodley <cbodley@redhat.com>
rgw: synchronize period config with period updates
read period config from local storage on RGWPeriod::update(), and write
the new config to storage on RGWPeriod::reflect()

Signed-off-by: Casey Bodley <cbodley@redhat.com>
rgw: load period config separately when there's no current period
Signed-off-by: Casey Bodley <cbodley@redhat.com>
rgw: constify some rgw_pool args
Signed-off-by: Casey Bodley <cbodley@redhat.com>
doc/rgw: update section on global quotas
Signed-off-by: Casey Bodley <cbodley@redhat.com>

@cbodley cbodley changed the title from radosgw-admin: new 'period quota' commands update period config to radosgw-admin: new 'global quota' commands update period config Apr 3, 2017

@cbodley

This comment has been minimized.

Contributor

cbodley commented Apr 3, 2017

thanks @oritwas, updated commands and docs to use global quota

@cbodley

This comment has been minimized.

@oritwas oritwas merged commit 8d701f6 into ceph:master Apr 5, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment