New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/vstart_runner: amend ps invocation #14254

Merged
merged 1 commit into from Mar 31, 2017

Conversation

Projects
None yet
2 participants
@idryomov
Contributor

idryomov commented Mar 30, 2017

"ps -xwwu" is parsed as BSD, because -x is not a UNIX option.
"u" is a BSD option for user-oriented format, so the ends up being
parsed as an old-style "select by pid". The only reason this command
doesn't dump other user's processes is that the BSD "only yourself"
restriction is in effect.

I'm not sure what's wrong with a simple "ps xww", but if we want to
select by euid, let's do it right.

Signed-off-by: Ilya Dryomov idryomov@gmail.com

@idryomov idryomov requested a review from jcsp Mar 30, 2017

qa/vstart_runner: amend ps invocation
"ps -xwwu<id>" is parsed as BSD, because -x is not a UNIX option.
"u" is a BSD option for user-oriented format, so the <id> ends up being
parsed as an old-style "select by pid".  The only reason this command
doesn't dump other user's processes is that the BSD "only yourself"
restriction is in effect.

I'm not sure what's wrong with a simple "ps xww", but if we want to
select by euid, let's do it right.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
@jcsp

This comment has been minimized.

Contributor

jcsp commented Mar 31, 2017

Looks reasonable, the x was only ever there from when it was originally "ps aux" and got hacked around several times.

@idryomov

This comment has been minimized.

Contributor

idryomov commented Mar 31, 2017

@jcsp I tested it by running test_full.py. Do you want to approve via github so I can merge or prefer to merge yourself?

@jcsp

jcsp approved these changes Mar 31, 2017

@jcsp jcsp merged commit 992b849 into ceph:master Mar 31, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@jcsp

This comment has been minimized.

Contributor

jcsp commented Mar 31, 2017

@idryomov thanks, I was just testing this earlier after reading it and then forgot until now :-)

@idryomov idryomov deleted the idryomov:wip-vstart-runner-ps branch Mar 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment