Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon/OSDMonitor: spinlock -> std::mutex #14269

Merged
merged 1 commit into from Apr 3, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Copy link
Member

liewegas commented Mar 31, 2017

I think spinlock is dangerous here: we're doing semi-unbounded
work (decode). Also seemingly innocuous code like dout macros
take mutexes.

Signed-off-by: Sage Weil sage@redhat.com

mon/OSDMonitor: spinlock -> std::mutex
I think spinlock is dangerous here: we're doing semi-unbounded
work (decode).  Also seemingly innocuous code like dout macros
take mutexes.

Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas requested a review from tchaikov Mar 31, 2017

@tchaikov
Copy link
Contributor

tchaikov left a comment

okay!

@songbaisen

This comment has been minimized.

Copy link

songbaisen commented Apr 1, 2017

yeah!

@liewegas

This comment has been minimized.

Copy link
Member Author

liewegas commented Apr 1, 2017

retest this please

@tchaikov tchaikov merged commit 65c8582 into ceph:master Apr 3, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.