New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: warning, ‘devno’ may be used uninitialized in this function #14271

Merged
merged 1 commit into from Apr 1, 2017

Conversation

Projects
None yet
4 participants
@joscollin
Member

joscollin commented Mar 31, 2017

The following warning appears during make. Fixed in both unmap_image() functions in krbd.cc

krbd.cc: In function ‘int krbd_unmap_by_spec(krbd_ctx*, const char*, const char*, const char*, const char*)’:
krbd.cc:608:65: warning: ‘devno’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   return do_unmap(ctx->udev, devno, build_unmap_buf(id, options));
                                                                 ^
krbd.cc:591:9: note: ‘devno’ was declared here
   dev_t devno;

Signed-off-by: Jos Collin jcollin@redhat.com

rbd: warning, ‘devno’ may be used uninitialized in this function
The following warning appears during make. Fixed in both unmap_image() functions in krbd.cc

--
krbd.cc: In function ‘int krbd_unmap_by_spec(krbd_ctx*, const char*, const char*, const char*, const char*)’:
krbd.cc:608:65: warning: ‘devno’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   return do_unmap(ctx->udev, devno, build_unmap_buf(id, options));
                                                                 ^
krbd.cc:591:9: note: ‘devno’ was declared here
   dev_t devno;
--

Signed-off-by: Jos Collin <jcollin@redhat.com>
@joscollin

This comment has been minimized.

Member

joscollin commented Apr 1, 2017

@dillaman Why the build failed ? Those errors are not related to these changes !

@dillaman

This comment has been minimized.

Contributor

dillaman commented Apr 1, 2017

retest this please

@badone badone merged commit fa3ddea into ceph:master Apr 1, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@joscollin joscollin deleted the joscollin:wip-krbd-warning branch Apr 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment