New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: let FreeBSD build ceph-fuse #14282

Merged
merged 1 commit into from Apr 5, 2017

Conversation

Projects
None yet
3 participants
@wjwithagen
Contributor

wjwithagen commented Apr 2, 2017

Signed-off-by: Willem Jan Withagen wjw@digiware.nl

echo start testing
date
(cd build; ctest -j$NPROC || ctest --rerun-failed --output-on-failure)

This comment has been minimized.

@tchaikov

tchaikov Apr 2, 2017

Contributor

the dependencies of ctest are built using "make tests", is it built anywhere in this script?

This comment has been minimized.

@wjwithagen

wjwithagen Apr 2, 2017

Contributor

@tchaikov
I guess they are made when doing

(cd build; gmake -j$NPROC $BUILDOPTS ceph-disk)
(cd build; gmake -j$NPROC $BUILDOPTS ceph-detect-init)

atleast it work for me every time, and ./build is on every run.

This comment has been minimized.

@tchaikov

tchaikov Apr 2, 2017

Contributor

okay, i am fine with this. but ceph-disk or ceph-detect-init does not even build ceph-osd.

This comment has been minimized.

@tchaikov

tchaikov Apr 3, 2017

Contributor

oic, you did gmake -j$NPROC $BUILDOPTS that basically builds everything. but you can save some time by "make tests", what do you think?

This comment has been minimized.

@wjwithagen

wjwithagen Apr 3, 2017

Contributor

@tchaikov

This way all steps are rather clear on what they do. Time saved for Building under FreeBSD is perhaps not the most important issue. Understandable and traceable out helps me more in catching problems.
I like to run the testing thru ctest, since that has a nice set of parameters to use

This comment has been minimized.

@tchaikov

tchaikov Apr 3, 2017

Contributor

@wjwithagen "make tests" does not run tests. it just builds the necessary bits for running tests. anyway, it's just my 2 cents.

@@ -912,8 +913,9 @@ if(WITH_LIBCEPHFS OR WITH_KRBD)
add_library(parse_secret_objs OBJECT ${parse_secret_files})
endif()
add_subdirectory(client)

This comment has been minimized.

@tchaikov

tchaikov Apr 2, 2017

Contributor

client is required only if WITH_LIBCEPHFS **or WITH_FUSE , am i right?

This comment has been minimized.

@wjwithagen

wjwithagen Apr 2, 2017

Contributor

@tchaikov
Yes, I was first hidding under WITH_LIBCEPFS but I needed it for WITH_FUSE.
There is however nothing very OS or LIB dependant stuff in there, so I figured to build it always.
Could conditionalise, if you prefer.

This comment has been minimized.

@tchaikov

tchaikov Apr 2, 2017

Contributor

okay, fair enough.

@@ -57,6 +57,7 @@ if [ x`uname`x = xFreeBSDx ]; then
www/py-flask \
www/fcgi \
sysutils/flock \
sysutils/fusefs-libs \

This comment has been minimized.

@tchaikov

tchaikov Apr 2, 2017

Contributor

nit, could you use spaces instead of tab? we don't have the modelines for emacs/vim in this file, so it would look unaligned this way with different default settings than tabstop=8.

This comment has been minimized.

@wjwithagen

wjwithagen Apr 2, 2017

Contributor

@tchaikov
Fixed spacing

@@ -912,8 +913,9 @@ if(WITH_LIBCEPHFS OR WITH_KRBD)
add_library(parse_secret_objs OBJECT ${parse_secret_files})
endif()
add_subdirectory(client)

This comment has been minimized.

@tchaikov

tchaikov Apr 2, 2017

Contributor

okay, fair enough.

build: let FreeBSD build ceph-fuse
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>

@tchaikov tchaikov added the needs-qa label Apr 3, 2017

@yuriw yuriw merged commit d302deb into ceph:master Apr 5, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@wjwithagen wjwithagen deleted the wjwithagen:wip-wjw-freebsd-ceph-fuse branch Apr 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment